-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run pre-commit on all files #1474
base: main
Are you sure you want to change the base?
Conversation
P.S. pre-commit also reports a few unused |
Indeed the trailing spaces in test were significant. |
Definitely seems problematic that running pre-commit with our config can break our tests |
87b9e82
to
f0ff476
Compare
f0ff476
to
ea6f6cf
Compare
Apparently trialing whitespace fixer doesn't understand Python multiline string literals. Re: RUF039, I think we should probably go through the half dozen instances where ruff insists on raw strings and update tests, wdyt? |
@@ -1810,7 +1810,7 @@ def test_breakpoint_good_names(self, request: pytest.FixtureRequest, name: str): | |||
'-', | |||
'...foo', | |||
'foo.bar', | |||
'bar--' 'FOO', | |||
'bar--FOO', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this was a bug, perhaps 'bar--', 'FOO'
was meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, looking at the original commit. Nice find!
Apparently pre-commit was not run on a few occasions and here's the diff.
I'm not sure about dangling whitespace in the pebble test.