Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow charms to select which charmcraft channel is used when updating charm libs #453

Merged

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Oct 24, 2024

Charms using these workflows may have charmcraft files not adapted yet to run with latest/stable charmcraft. Please allow the github repo to define which charmcraft version to use

Overview

Makes the charmcraft-channel optional

Rationale

I'm maintaining some charms which require charmcraft 2.x

Workflow Changes

None

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@addyess addyess requested a review from a team as a code owner October 24, 2024 16:13
@addyess
Copy link
Contributor Author

addyess commented Oct 24, 2024

@weiiwang01 i think this is an easy one

Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturo-seijas arturo-seijas merged commit ca65a7b into canonical:main Oct 25, 2024
71 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants