Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the --charm-file option format in integration tests #180

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

weiiwang01
Copy link
Collaborator

Under certain circumstances, pytest may incorrectly interpret the value of the --charm-file option as the positional argument [file_or_dir] of the pytest command line arguments. This error results in the pytest test root directory shifting from ./tests to .. To prevent this issue, modify the format of the --charm-file option.

@weiiwang01 weiiwang01 requested a review from a team as a code owner August 4, 2023 16:04
mthaddon
mthaddon previously approved these changes Aug 4, 2023
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiiwang01 weiiwang01 merged commit 25664be into main Aug 7, 2023
@weiiwang01 weiiwang01 deleted the fix-charm-file branch August 7, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants