Fix a possible cause of crashes in free() #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
force-pushed
the
fix-free-crashes
branch
8 times, most recently
from
459a295 to
db8aa2d
Compare
While requesting for the next array of random bytes we were cleary malloc'ing memory of the wrong size (sizeof(length) instead of length). This commit includes the bug fix and re-enables SecureRandomTest.
pushkarnk
force-pushed
the
fix-free-crashes
branch
from
db8aa2d to
53fbc70
Compare
|
Manually triggered the GitHub Action 5 times. No failures seen. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While requesting for the next array of random bytes we were cleary malloc'ing memory of the wrong size (sizeof(length) instead of length).
This commit includes the bug fix and re-enables SecureRandomTest.