Add revision to the dashboard title of the Grafana #510
Conversation
With this change, two different OpenSearch applications, in different revisions, will have separate dashboards when related to COS. - data-platform-helpers was added to use the get_charm_revision - titles of dashboards are changed during the charm upgrade hook - config_changed was added on refresh_events of COSAgentProvider to re-render the dashboards after a charm upgrade
gabrielcocenza
requested review from
zmraul,
phvalguima,
marcoppenheimer and
delgod
| @@ -244,6 +244,7 @@ def __init__(self, *args, distro: Type[OpenSearchDistribution] = None): | |||
| metrics_endpoints=[], | |||
| scrape_configs=self._scrape_config, | |||
| refresh_events=[ | |||
| self.on.config_changed, | |||
There was a problem hiding this comment.
question: Why is this one needed?
There was a problem hiding this comment.
The COSAgentProvider has self.on.config_changed by default if no custom events are passed.
We are passing custom events, so there is no refresh on COS for config-changed.
When you upgrade a charm, after that the config-change hook is triggered.
In summary, I'm re adding the default behavior and at the same time cover my need of refreshing COS relation after charm upgrade
There was a problem hiding this comment.
Another thing...
I didn't add self.on_charm_upgrade because I was seeing a race condition. Talking with the COS team, the order when you add those handlers matters and COS Provider should in theory be added as a last handler.
To do that, we would need to move the COSAgentProvider to the last child class of the inheritance and I though that it would be simpler just add back the config-changed
There was a problem hiding this comment.
Shouldn't we refresh on COS broken event as well? It is a slightly off topic question for this PR but how can we assure the dashboard is gone if we remove the COS relation from opensearch?
There was a problem hiding this comment.
I've tested and as expected (at least for me), the dashboards are removed if the relation with grafana-agent is removed
With this change, two different OpenSearch applications in different revisions, will have separate dashboards when related to COS.
How to test it