Add CI and unit tests for prometheus rules using promtool #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It's good to have unit tests for the prometheus alerts and also check if the prometheus_alerts.yaml is a valid file. - using promtool is possible to check the rules and also run unit tests for the alerts.
gabrielcocenza
force-pushed
the
promtool-ci
branch
from
a3bfbfe to
a1e3970
Compare
- remove decimal values from reject_ratio
phvalguima
reviewed
Dec 11, 2024
- call promtool tests from ci.yaml
phvalguima
approved these changes
Dec 18, 2024
zmraul
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's good to have unit tests for the prometheus alerts and also check if the prometheus_alerts.yaml is a valid file.
using promtool is possible to check the rules and also run unit tests.
How to test this PR
promtool check rules src/alert_rules/prometheus/*.yaml