Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backup] Add error handling to _request #238

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

phvalguima
Copy link
Contributor

@phvalguima phvalguima commented Apr 15, 2024

Updates the backup lib to consider the new error handling with OpenSearchHttpError and request() method.

Also removes a lingering "MaintenanceStatus" if we have a configuration error in the backups.

@phvalguima phvalguima marked this pull request as ready for review April 15, 2024 19:25
@phvalguima phvalguima changed the title Add error handling to _request [Backup] Add error handling to _request Apr 16, 2024
lib/charms/opensearch/v0/opensearch_backups.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro, I have a comment

@phvalguima phvalguima merged commit a1c0d94 into main Apr 19, 2024
22 of 26 checks passed
@phvalguima phvalguima deleted the fix-backup-error-handling branch April 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants