Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if alt_hosts are reachable & online instead of reachable #215

Merged
merged 12 commits into from
Apr 12, 2024

Conversation

carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical commented Apr 5, 2024

Definitions
Reachable: Successful socket connection
Online: Successful HTTP GET request to /_nodes

Fixes uncaught OpenSearchHttpError (status code 503): OpenSearch Security not initialized. (Fixes transient integration test failure—test 1 from #211 (comment))

Definitions
Reachable: Successful socket connection
Online: Successful HTTP GET request to `/_nodes`

Fixes uncaught OpenSearchHttpError (status code 503): OpenSearch Security not initialized. (Fixes transient integration test failure—test 1 from #211 (comment))
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a couple of nits

lib/charms/opensearch/v0/opensearch_distro.py Outdated Show resolved Hide resolved
lib/charms/opensearch/v0/opensearch_distro.py Outdated Show resolved Hide resolved
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Apr 5, 2024
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Apr 10, 2024
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

phvalguima
phvalguima previously approved these changes Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants