generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if alt_hosts are reachable & online instead of reachable #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitions Reachable: Successful socket connection Online: Successful HTTP GET request to `/_nodes` Fixes uncaught OpenSearchHttpError (status code 503): OpenSearch Security not initialized. (Fixes transient integration test failure—test 1 from #211 (comment))
carlcsaposs-canonical
requested review from
juditnovak,
phvalguima and
Mehdi-Bendriss
April 5, 2024 12:05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a couple of nits
Co-authored-by: Mehdi Bendriss <[email protected]>
Mehdi-Bendriss
previously approved these changes
Apr 5, 2024
carlcsaposs-canonical
force-pushed
the
alt-hosts-online
branch
from
April 10, 2024 11:00
b3b802f
to
d1ed110
Compare
Mehdi-Bendriss
previously approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
phvalguima
previously approved these changes
Apr 10, 2024
carlcsaposs-canonical
dismissed stale reviews from phvalguima and Mehdi-Bendriss
via
April 12, 2024 07:21
8a0b4c5
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions
Reachable: Successful socket connection
Online: Successful HTTP GET request to
/_nodes
Fixes uncaught OpenSearchHttpError (status code 503): OpenSearch Security not initialized. (Fixes transient integration test failure—test 1 from #211 (comment))