-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3136][DPE-3137] Add dpe-workflows & poetry #178
Conversation
c73ba28
to
201f4a4
Compare
04197a8
to
7d41c5d
Compare
060072f
to
2f9fed7
Compare
1faf251
to
616cedb
Compare
616cedb
to
d556b89
Compare
The check is failing: |
d556b89
to
433ca8b
Compare
22cb1a8
to
c938281
Compare
433ca8b
to
f20e5c8
Compare
670fd98
to
9949059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for migrating to data-platform-workflows! also appreciate all the bug reports & feature requests on dpw
f20e5c8
to
cd9f197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poetry.lock should be version controlled
7114625
to
2f7dd8d
Compare
0f77e37
to
18fc288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pedro. I left some comments.
27d7db4
to
5331546
Compare
17a5444
to
e806bdc
Compare
a21604b
to
cfdc018
Compare
912b8b0
to
ebe4129
Compare
The base branch was changed.
ebe4129
to
80126cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pedro. I left 1 comments that can be addressed in another PR
Address this comment: #178 (comment)
This PR moves the opensearch-operator to use data-platform-workflows repo, it adds more behaviors to backups, as described below; and extends its integration testing.
Moving to data-platform-workflows brings opensearch to the same level in its testing infrastructure as other operators. It also enables testing to easily consume secrets from Github, as well as other features such as redact-secrets or support for self-hosted runners. This move covers DPE-3136 and DPE-3137. Now, opensearch-operator supports Poetry and can use poetry.lock to pin dependencies.
Important movements, besides changing to dpe-workflows:
reset_restart_delay
,c_writes
,c_writes_runner
andc_balanced_writes_runner
to a single place:tests/integration/ha/conftest.py
tests/integration/conftest.py
as the build process is now executed by the DPE workflowstests/conftest.py
, as it was used for secrets management between 2.9 and 3.x, besides the new workflow uses relative paths starting intests/unit
andtests/integration
folderstests/integration/relations/opensearch_provider/
totests/integration/relations
for the sake of simplifying relative pathsapplication_charm
intests/integration/relations
folderThe backup test has been removed and will be readded in DPE-2999 PR.