Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3136][DPE-3137] Add dpe-workflows & poetry #178

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

phvalguima
Copy link
Contributor

@phvalguima phvalguima commented Feb 6, 2024

This PR moves the opensearch-operator to use data-platform-workflows repo, it adds more behaviors to backups, as described below; and extends its integration testing.

Moving to data-platform-workflows brings opensearch to the same level in its testing infrastructure as other operators. It also enables testing to easily consume secrets from Github, as well as other features such as redact-secrets or support for self-hosted runners. This move covers DPE-3136 and DPE-3137. Now, opensearch-operator supports Poetry and can use poetry.lock to pin dependencies.

Important movements, besides changing to dpe-workflows:

  • Moves methods that are repeated several times: reset_restart_delay, c_writes, c_writes_runner and c_balanced_writes_runner to a single place: tests/integration/ha/conftest.py
  • Removes tests/integration/conftest.py as the build process is now executed by the DPE workflows
  • Removes the root tests/conftest.py, as it was used for secrets management between 2.9 and 3.x, besides the new workflow uses relative paths starting in tests/unit and tests/integration folders
  • Moves the tests declared in tests/integration/relations/opensearch_provider/ to tests/integration/relations for the sake of simplifying relative paths
  • Adds a local build of application_charm in tests/integration/relations folder

The backup test has been removed and will be readded in DPE-2999 PR.

@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch 2 times, most recently from c73ba28 to 201f4a4 Compare February 6, 2024 11:21
@phvalguima phvalguima marked this pull request as ready for review February 6, 2024 11:35
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from 04197a8 to 7d41c5d Compare February 7, 2024 17:10
@phvalguima phvalguima changed the base branch from main to DPE-3352-last-passing-tests February 7, 2024 17:10
@phvalguima phvalguima force-pushed the DPE-3352-last-passing-tests branch from 060072f to 2f9fed7 Compare February 12, 2024 19:29
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from 1faf251 to 616cedb Compare February 17, 2024 06:34
@phvalguima phvalguima removed the request for review from Mehdi-Bendriss February 17, 2024 06:52
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from 616cedb to d556b89 Compare February 17, 2024 06:59
@phvalguima
Copy link
Contributor Author

The check is failing: app: opensearch blocked -- message: 1 or more 'replica' shards are not assigned, please scale your application up. and timing out
It is not related to this change.
Full check here: https://github.com/canonical/opensearch-operator/actions/runs/7940046438/job/21680946956?pr=178

@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from d556b89 to 433ca8b Compare February 19, 2024 06:34
@phvalguima phvalguima force-pushed the DPE-3352-last-passing-tests branch from 22cb1a8 to c938281 Compare February 19, 2024 10:06
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from 433ca8b to f20e5c8 Compare February 19, 2024 10:29
@phvalguima phvalguima force-pushed the DPE-3352-last-passing-tests branch from 670fd98 to 9949059 Compare February 19, 2024 14:18
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for migrating to data-platform-workflows! also appreciate all the bug reports & feature requests on dpw

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from f20e5c8 to cd9f197 Compare February 19, 2024 15:11
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poetry.lock should be version controlled

@phvalguima phvalguima force-pushed the DPE-3352-last-passing-tests branch 2 times, most recently from 7114625 to 2f7dd8d Compare February 23, 2024 10:18
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch 2 times, most recently from 0f77e37 to 18fc288 Compare February 24, 2024 20:04
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro. I left some comments.

.github/workflows/release.yaml Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
tests/integration/ha/helpers.py Outdated Show resolved Hide resolved
tests/integration/ha/test_ha_networking.py Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
tests/integration/ha/helpers.py Outdated Show resolved Hide resolved
@phvalguima phvalguima force-pushed the DPE-3352-last-passing-tests branch from 27d7db4 to 5331546 Compare February 29, 2024 03:17
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch 2 times, most recently from 17a5444 to e806bdc Compare February 29, 2024 03:20
@phvalguima phvalguima force-pushed the DPE-3352-last-passing-tests branch from a21604b to cfdc018 Compare February 29, 2024 11:03
@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from 912b8b0 to ebe4129 Compare February 29, 2024 12:23
Base automatically changed from DPE-3352-last-passing-tests to main March 1, 2024 16:17
@phvalguima phvalguima dismissed carlcsaposs-canonical’s stale review March 1, 2024 16:17

The base branch was changed.

@phvalguima phvalguima force-pushed the DPE-3136-DPE-3137-move-poetry-dp-workflows branch from ebe4129 to 80126cf Compare March 1, 2024 16:25
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pedro. I left 1 comments that can be addressed in another PR

tests/integration/ha/helpers.py Show resolved Hide resolved
phvalguima added a commit that referenced this pull request Mar 4, 2024
Address this comment: #178 (comment)
@phvalguima phvalguima merged commit 99103c5 into main Mar 4, 2024
21 of 23 checks passed
@phvalguima phvalguima deleted the DPE-3136-DPE-3137-move-poetry-dp-workflows branch March 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants