Log HTTP errors & retry (on next event) instead of re-raising

canonical · Apr 17, 2024 · 04eefc6 · 04eefc6
1 parent 0e1b6b1
commit 04eefc6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/charms/opensearch/v0/opensearch_locking.py b/lib/charms/opensearch/v0/opensearch_locking.py
@@ -187,7 +187,8 @@ def acquired(self) -> bool:  # noqa: C901
                     # Index already created
                     pass
                 else:
-                    raise
+                    logger.exception("Error creating OpenSearch lock index")
+                    return False
             # Attempt to create document id 0
             try:
                 self._opensearch.request(
@@ -212,7 +213,8 @@ def acquired(self) -> bool:  # noqa: C901
                         )
                         return False
                 else:
-                    raise
+                    logger.exception("Error creating OpenSearch lock document")
+                    return False
             # Lock acquired
             # Release peer databag lock, if any
             logger.debug("[Node lock] Acquired via opensearch")