feat: display version in UI #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
saltiyazan
approved these changes
Sep 26, 2024
kayra1
reviewed
Sep 26, 2024
Comment on lines
+19
to
+25
| useEffect(() => { | ||
| const fetchStatus = async () => { | ||
| const statusData = await getStatus(); | ||
| setStatus(statusData); | ||
| }; | ||
| fetchStatus(); | ||
| }, []); |
There was a problem hiding this comment.
I would usually avoid useEffect when making queries because there are a ton of pitfalls. Here for example we will be refetching the version every time this component redraws since there is no dependencies listed.
We should use react-query, which honestly is way simpler to use and understand:
const queryClient = useQueryClient()
const query = useQuery({ queryKey: [], queryFn: getStatus })
const version = query.data?.version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display the Notary version in the UI leveraging the new /status endpoint.
Fixes #66
Screenshot
Checklist: