-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Canonical react components #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruyaume
changed the title
chore: use Canonical react components
chore: use Canonical react components (Initialize)
Sep 16, 2024
gruyaume
changed the title
chore: use Canonical react components (Initialize)
chore: use Canonical react components (Initialize and Login)
Sep 16, 2024
gruyaume
changed the title
chore: use Canonical react components (Initialize and Login)
chore: use Canonical react components
Sep 16, 2024
gruyaume
changed the title
chore: use Canonical react components
chore: use Canonical react components (pt.1)
Sep 16, 2024
gruyaume
changed the title
chore: use Canonical react components (pt.1)
chore: use Canonical react components
Sep 16, 2024
kayra1
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress on this refactor
kayra1
reviewed
Sep 18, 2024
kayra1
approved these changes
Sep 23, 2024
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Signed-off-by: guillaume <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Canonical react components instead of having custom html components.
Rationale
This change allows:
I believe now's the right time to do this change before this project grows.
Visual Improvements
This change comes with some visual improvements.
In each image:
Better login and initialization pages
Instead of coding our own layout and logic for the login and initialization pages, we now use canonical's
LoginPageLayout
which reduces the amount of code by a bunch and looks nice.A show CSR content action
We removed the additional action button that shows certificate content and replaced it with an additional action in the action menu named "Show CSR Content". This leverages Canonical MainTable's expanded row feature instead of coding our own.
Better input validation visuals
We leverage the "error" parameter in
Input
components automatically rendering the boxes red and using the appropriate icon instead of coding our own logic. It also looks nicer.What's next?
Yes, there are more aspects of the code that could be converted to using react components. Here I did a large first batch of changes. There will be more to come, namely:
Checklist: