-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exposes baseline metrics #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruyaume
requested changes
Apr 30, 2024
kayra1
requested changes
Apr 30, 2024
Converted to draft, figuring out why are unit tests failing |
Creates a package for metrics where handlers are moved
saltiyazan
force-pushed
the
TLSENG-225-exposes-baseline-metrics
branch
from
May 2, 2024 07:23
d2d383c
to
8ae91a9
Compare
saltiyazan
force-pushed
the
TLSENG-225-exposes-baseline-metrics
branch
from
May 2, 2024 09:08
ad11777
to
c7442d4
Compare
gruyaume
reviewed
May 2, 2024
MetricsHandler interface is removed Handler is instantiated in handlers.go
gruyaume
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kayra1
requested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect. just one small thing.
kayra1
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The solution creates a custom handler for the
metrics
endpoint, that handler will run for any collectors registered in the metrics registry, for now we only have the collector of some basic Go metrics, but this should be easy to extend in the future with custom collectors.To test this, run the service and curl the
/metrics
endpoint.To test this with prometheus, configure prometheus with the following job:
Run prometheus then curl the metrics endpoint of prometheus, for example:
`curl http://localhost:9090/metrics | grep gocerts'
Checklist: