Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use react query for getting version #100

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: use react query for getting version #100

merged 1 commit into from
Sep 26, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Sep 26, 2024

Description

This change modifies the version query from useEffect to react-query. This allows us to have some extra error protection if the call fails and also avoid sending a request every time the UI is rerendered.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 requested a review from a team as a code owner September 26, 2024 18:40
@kayra1 kayra1 changed the title feat: use react query for getting version chore: use react query for getting version Sep 26, 2024
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of this practice, good to know!

@kayra1 kayra1 merged commit 83a7ca0 into main Sep 26, 2024
14 checks passed
@kayra1 kayra1 deleted the version-ui branch September 26, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants