[WIP] Charm logging tracing integration #405
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based upon #392
Logs --> traces
If a charm is using
charm_tracing
andcharm_logging
(and both are active and healthy), we should be able to link traces and logs generated by each charm execution.This PR links logs to traces by:
Open questions/challenges
charm_logging
decorator needs to be applied before thecharm_tracing
one, otherwise logging will be unaware of the tracing context and fail to acknowledge the root span id.Resources:
https://grafana.com/docs/grafana/latest/datasources/loki/#provision-the-data-source