Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SSL Certificates not properly surfaced #286

Conversation

david-mclain
Copy link
Contributor

Manual Testing

Verify Bug

  • Download landscape client and place self signed server certificate in an unreadable directory by landscape
  • Try to connect client to server using the following command
    landscape-config --account standalone --url https://<server-ip>/message-system --ping-url https://server-ip/ping -k ssl-cert-location
  • Code should fail and provide no information as to why it fails

Verify Fix

  • Repeat above steps but instead using this version
  • Verify that warning message is provided by logs

@david-mclain david-mclain requested a review from srunde3 November 22, 2024 17:20
Copy link
Contributor

@srunde3 srunde3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I tested using a file path that didn't exist, and that also logged a warning message (as expected). 🚀

@david-mclain david-mclain merged commit 1449b56 into canonical:main Nov 27, 2024
5 checks passed
@david-mclain david-mclain deleted the lndeng-1820-ssl-certs-not-properly-surfaced branch December 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants