Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure preferences.d directory exists in created APT dirs #254

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Perfect5th
Copy link
Contributor

Ubuntu 24.04 and higher expect the preferences.d directory to exist in any directory being treated as an APT config directory. Creation of this directory was missing in AptFacade, which was leading to warnings when running some tests, such as andscape.lib.apt.package.tests.test_facade.AptFacadeTest.test_custom_root_create_required_files.

Copy link
Contributor

@wck0 wck0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the warning on the specified test is no longer emitted in noble after this change.

:shipit:

@Perfect5th Perfect5th merged commit a4de0b0 into canonical:main Aug 20, 2024
4 checks passed
@Perfect5th Perfect5th deleted the fix-apt-cache-warnings branch August 20, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants