fix: remove --containerd Kubelet cAdvisor arg.
#835
Merged
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @aznashwan -- might need a bit more description here. But i understand why we don't need this argument |
|
Is it not needed, or is it in use but deprecated? |
aznashwan
force-pushed
the
remove-kubelet-containerd-arg
branch
2 times, most recently
from
7411a7f
to
cebb1e1
Compare
aznashwan
changed the title
--containerd argument from kubelet.--containerd Kubelet cAdvisor arg.
This patch removes the passing of the `--containerd` argument (value should be path to containerd socket) to `kubelet`. This argument is actually not a kubelet argument per se, but instead it is a cAdvisor argument (1) which was accidentally transparently declared and shipped in kubelet a very long time ago, but had been explicitly declared within kubelet and marked deprecated since 2017 (2). [1] https://github.com/google/cadvisor/blob/3888dda254a8fa12f1c96be24ffdc33288ea9071/container/containerd/factory.go#L34 [2] https://github.com/kubernetes/kubernetes/pull/57613/files#diff-fecc7baa0b61f11d37dfc453aef25acca98866e1924f7765ba5592ca58fc3045R143 Signed-off-by: Nashwan Azhari <[email protected]>
aznashwan
force-pushed
the
remove-kubelet-containerd-arg
branch
from
cebb1e1
to
3fd082a
Compare
bschimke95
approved these changes
Nov 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Nov 24, 2024
This patch removes the passing of the `--containerd` argument (value should be path to containerd socket) to `kubelet`. This argument is actually not a kubelet argument per se, but instead it is a cAdvisor argument (1) which was accidentally transparently declared and shipped in kubelet a very long time ago, but had been explicitly declared within kubelet and marked deprecated since 2017 (2). [1] https://github.com/google/cadvisor/blob/3888dda254a8fa12f1c96be24ffdc33288ea9071/container/containerd/factory.go#L34 [2] https://github.com/kubernetes/kubernetes/pull/57613/files#diff-fecc7baa0b61f11d37dfc453aef25acca98866e1924f7765ba5592ca58fc3045R143 Signed-off-by: Nashwan Azhari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch stops passing the
--containerdargument (value should be path to containerd socket) tokubelet.This argument's backstory is a bit of a doozy but I'll try to lay it out:
Thus, this setting does not SEEM to be relevant for the k8s-snap.
The actual containerd socket is correctly passed as the
--container-runtime-endpointright above it FWIW.I am unfortunately unsure why its presence is producing the
POST /k8sd/cluster: Post "http://control.socket/1.0/k8sd/cluster": EOFerror onk8s bootstrapwe've been seeing, but I can vouch from my manual testing that removing it works around that particular crash