-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for cis hardening #802
base: main
Are you sure you want to change the base?
Conversation
ktsakalozos
commented
Nov 15, 2024
- update the CIS hardening how-to with CIS auditing section
- update the CIS reports generation tool to give us the format we want
- update the CIS hardening checks to include dqlite in place of etcd
- review the CIS hardening checks
Hi, looks like pyspelling job found some issues, you can check it here |
e1460cd
to
d256e66
Compare
4bd95e5
to
1aa546f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @nhennigan to give final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a few cases where the expected output did not match the remediation suggestion. If this is meant to be the expected output of the system as is when shipped then ignore my comments but we should make that clear.
We also have (automated) and (manual) beside all audit steps. Do we mean that automated steps should be configured by default? If so there were a few on my local tests that were labeled (automated) but not set