Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass URLs through CDN #549

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat: pass URLs through CDN #549

merged 1 commit into from
Jul 25, 2024

Conversation

M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Jul 25, 2024 •
edited by jira bot
Loading

Done

  • Pass asset URLs through CDN

QA

  • Go to docs,
  • make sure assets work fine
  • make sure no warning about lookalike URL (on chrome)

Issue / Card

Fixes WD-13287

@webteam-app
Copy link

Demo

Jenkins

demos.haus

Lukewh
Lukewh approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@M7mdisk M7mdisk force-pushed the WD-13287/proxy-assets branch from bd98deb to ed8dddc Compare July 25, 2024 12:38
@M7mdisk M7mdisk merged commit 289cf15 into main Jul 25, 2024
6 checks passed
@M7mdisk M7mdisk deleted the WD-13287/proxy-assets branch July 25, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukewh Lukewh Lukewh approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M7mdisk @webteam-app @Lukewh