Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copy): Update operator-day pages #508

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Jan 9, 2024

Done

  • Update copy as-per the copy doc

QA

Issue / Card

Fixes WD-8142

@webteam-app
Copy link

Demo starting at https://juju-is-508.demos.haus

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d35d49) 58.51% compared to head (54f4a3f) 58.51%.
Report is 2 commits behind head on main.

❗ Current head 54f4a3f differs from pull request most recent head 985a465. Consider uploading reports for the commit 985a465 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files           6        6           
  Lines         188      188           
=======================================
  Hits          110      110           
  Misses         78       78           
Flag Coverage Δ
python 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment in the code to update them LGTM 👍


<p>Come and join our new edition of Operator Day colocated at KubeCon NA 2023 a virtual online event, free to attend</p>
<p>The most recent Operator Day covered the entire journey of an engineering team, exploring software operators with hands-on sessions. Based on feedback from previous attendees, we covered the step-by-step creation of an operator for <a href="https://juju.is/">Juju</a>, called a charm, using the <a href="https://juju.is/docs/sdk">Charm SDK</a>. The programme included:</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks should be relative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated

@Lukewh Lukewh force-pushed the operator-day-2024 branch from d45bc32 to debda06 Compare January 9, 2024 09:58
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lukewh Lukewh force-pushed the operator-day-2024 branch from debda06 to 54f4a3f Compare January 9, 2024 10:03
@mcjaeger
Copy link

mcjaeger commented Jan 9, 2024

I am sorry, I missed to remove a button - could that be removed please, it points to an outdated page.
Screenshot 2024-01-09 at 11 20 15

@Lukewh Lukewh force-pushed the operator-day-2024 branch from 54f4a3f to 985a465 Compare January 9, 2024 10:29
@mcjaeger
Copy link

mcjaeger commented Jan 9, 2024

+1 - LGTM

@Lukewh Lukewh merged commit 241c005 into canonical:main Jan 9, 2024
6 checks passed
@Lukewh Lukewh deleted the operator-day-2024 branch January 9, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants