-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(copy): Update operator-day pages #508
Conversation
Demo starting at https://juju-is-508.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 6 6
Lines 188 188
=======================================
Hits 110 110
Misses 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment in the code to update them LGTM 👍
templates/operator-day/index.html
Outdated
|
||
<p>Come and join our new edition of Operator Day colocated at KubeCon NA 2023 a virtual online event, free to attend</p> | ||
<p>The most recent Operator Day covered the entire journey of an engineering team, exploring software operators with hands-on sessions. Based on feedback from previous attendees, we covered the step-by-step creation of an operator for <a href="https://juju.is/">Juju</a>, called a charm, using the <a href="https://juju.is/docs/sdk">Charm SDK</a>. The programme included:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks should be relative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, updated
d45bc32
to
debda06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
debda06
to
54f4a3f
Compare
54f4a3f
to
985a465
Compare
+1 - LGTM |
Done
QA
Issue / Card
Fixes WD-8142