Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove access to dashboard from jaas.ai #737

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: Remove access to dashboard from jaas.ai #737

merged 1 commit into from
Nov 23, 2023

Conversation

vladimir-cucu
Copy link
Contributor

Done

  • Removed all access points to juju-dashboard from jaas.ai
  • Removed all remaining artifacts related to juju-dashboard

QA

  • Pull code
  • Run dotrun
  • Open http://0.0.0.0:8029
  • Make sure that "/models", "/models/path:path", "/controllers", "/controllers/path:path", "/config.js", "/manifest.json", "/version.json", "/ghost-bundle.svg" routes are not accessible

Details

huwshimi
huwshimi approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vladimir-cucu vladimir-cucu merged commit 510172b into canonical:main Nov 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimir-cucu @huwshimi