Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chose: loose Pydantic 2 version constraint #74

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

sinclert-canonical
Copy link
Contributor

@sinclert-canonical sinclert-canonical commented Nov 28, 2024

This PR loose the constraints around the Pydantic dependency to allow versions bigger than 2.5.x.

This change is required so other charms could use this charm's library, without needing to stick to Pydantic 2.5.x

@sinclert-canonical sinclert-canonical requested a review from a team as a code owner November 28, 2024 10:17
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. LGTM, other than a few small nit-picks

requirements.txt Outdated Show resolved Hide resolved
lib/charms/glauth_utils/v0/glauth_auxiliary.py Outdated Show resolved Hide resolved
lib/charms/glauth_k8s/v0/ldap.py Outdated Show resolved Hide resolved
@nsklikas nsklikas enabled auto-merge November 28, 2024 12:13
auto-merge was automatically disabled November 28, 2024 13:47

Head branch was pushed to by a user without write access

@nsklikas nsklikas merged commit d86e301 into canonical:main Nov 28, 2024
3 checks passed
@sinclert-canonical sinclert-canonical deleted the pydantic-versions branch November 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants