Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add integration testcases #24

Merged
merged 1 commit into from
Feb 13, 2024
Merged

test: add integration testcases #24

merged 1 commit into from
Feb 13, 2024

Conversation

wood-push-melon
Copy link
Contributor

@wood-push-melon wood-push-melon commented Feb 12, 2024 •
edited
Loading

This pull request uses the any-charm to add more integration tests to cover multiple juju integrations required/offered by glauth-k8s charmed operator.

@wood-push-melon wood-push-melon marked this pull request as ready for review February 12, 2024 22:45
@wood-push-melon wood-push-melon requested a review from a team as a code owner February 12, 2024 22:45
natalian98
natalian98 reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@natalian98 natalian98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you add missing copyright notices?

tests/integration/conftest.py Show resolved Hide resolved
tests/integration/tester.py Show resolved Hide resolved
@wood-push-melon wood-push-melon merged commit 77ce6da into main Feb 13, 2024
3 checks passed
@wood-push-melon wood-push-melon deleted the IAM-667 branch February 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalian98 natalian98 natalian98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wood-push-melon @natalian98