-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IAM-286 preliminary commit for charm base #15
Conversation
3b50bfa
to
7fb1d3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, but I have some comments. I suppose we are going to rework the kubernetes_resource
logic either way (we should use the same logic in all of our charms).
a8664aa
to
3e6e48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final comment. Also a lot of functions are missing return type annotations (and there are some other typing errors). Running mypy
should show you whatever issues there are. It does not make sense to fix some of them, but let's try to resolve as many as possible.
What
This pull request aims to provide the preliminary version of the GLAuth base charm.
I'm sorry this pull request is chunky since it's based on the code used in the demo. Please focus on the code under
src
when reviewing.What's inside
Improvements on the way