Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make uv plugin re-entrant on code changes #956

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Jan 7, 2025

  • Have you signed the CLA?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

When changing source code, the uv plugin would not use the new code without first cleaning out the parts build space. This PR fixes that.

Based off of #955.

Needed by canonical/snapcraft#5196.
CRAFT-3841

bepri added 2 commits January 7, 2025 15:48
The pyproject file referenced some deprecated Ruff linter rules and incorrectly formatted the git describe command parameter, which had to be an array. This commit fixes both
@bepri bepri requested review from lengau and mr-cal January 7, 2025 21:12
@bepri bepri self-assigned this Jan 7, 2025
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge after #955

Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/reference/changelog.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned a new word today.

@bepri bepri merged commit a35ccbf into main Jan 8, 2025
13 checks passed
@bepri bepri deleted the work/uv-plugin-hotfix/CRAFT-3841 branch January 8, 2025 18:25
@bepri bepri restored the work/uv-plugin-hotfix/CRAFT-3841 branch January 8, 2025 18:31
@bepri bepri deleted the work/uv-plugin-hotfix/CRAFT-3841 branch January 8, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants