-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: pin urllib3 version to prevent request problems #440
Conversation
cmatsuoka
commented
May 5, 2023
- Have you signed the CLA?
Signed-off-by: Claudio Matsuoka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is related to requests_unixsocket
and someone has opened a PR on it: msabramo/requests-unixsocket#69
Could you include that link in the comment so it's easy in future to see why we pinned urllib3 <2.?
Maybe we can stop use that |
@syu-w probably... The project seems to be pretty inactive on freedesktop.org (https://gitlab.freedesktop.org/xdg/pyxdg), so I'm not sure whether it's considered actively maintained. The lack of response from maintainers on pull requests leads me towards thinking it's not, but I've bumped the xdg mailing list about it. For what we use it for, implementing the standard directly ourselves probably wouldn't be that bad, but from a "health of the community" perspective I'd rather see the package updated. |
I mean not because it is inactive, but the xdg compatibility issues. There are multiple xdg packages and the system one seems could broke the one install from pip. |
Co-authored-by: Alex Lowe <[email protected]> Signed-off-by: Claudio Matsuoka <[email protected]>
Also including the xdg pyright workaround to avoid dependency deadlock. |
…cal#440) * requirements: pin urllib3 version to prevent request problems * lint: temporary workaround for pyxdg pyright issues Co-authored-by: Alex Lowe <[email protected]> Signed-off-by: Claudio Matsuoka <[email protected]>