Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: pin urllib3 version to prevent request problems #440

Merged
merged 2 commits into from
May 9, 2023

Conversation

cmatsuoka
Copy link
Collaborator

  • Have you signed the CLA?

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is related to requests_unixsocket and someone has opened a PR on it: msabramo/requests-unixsocket#69

Could you include that link in the comment so it's easy in future to see why we pinned urllib3 <2.?

@syu-w
Copy link
Contributor

syu-w commented May 9, 2023

Maybe we can stop use that pyxdg package?

@lengau
Copy link
Contributor

lengau commented May 9, 2023

@syu-w probably... The project seems to be pretty inactive on freedesktop.org (https://gitlab.freedesktop.org/xdg/pyxdg), so I'm not sure whether it's considered actively maintained. The lack of response from maintainers on pull requests leads me towards thinking it's not, but I've bumped the xdg mailing list about it.

For what we use it for, implementing the standard directly ourselves probably wouldn't be that bad, but from a "health of the community" perspective I'd rather see the package updated.

@syu-w
Copy link
Contributor

syu-w commented May 9, 2023

@syu-w probably... The project seems to be pretty inactive on freedesktop.org (https://gitlab.freedesktop.org/xdg/pyxdg), so I'm not sure whether it's considered actively maintained. The lack of response from maintainers on pull requests leads me towards thinking it's not, but I've bumped the xdg mailing list about it.

For what we use it for, implementing the standard directly ourselves probably wouldn't be that bad, but from a "health of the community" perspective I'd rather see the package updated.

I mean not because it is inactive, but the xdg compatibility issues. There are multiple xdg packages and the system one seems could broke the one install from pip.

Co-authored-by: Alex Lowe <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
@cmatsuoka
Copy link
Collaborator Author

Also including the xdg pyright workaround to avoid dependency deadlock.

@cmatsuoka cmatsuoka merged commit 0ba53db into canonical:main May 9, 2023
@cmatsuoka cmatsuoka deleted the pin-urllib3 branch May 9, 2023 18:00
cmatsuoka added a commit to cmatsuoka/craft-parts that referenced this pull request May 19, 2023
…cal#440)

* requirements: pin urllib3 version to prevent request problems
* lint: temporary workaround for pyxdg pyright issues

Co-authored-by: Alex Lowe <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants