Add groups dependency support #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@sergiusens Ok, moved into craft-parts. Now we need to think a good name for the parameter, instead of "groups". |
sergio-costas
force-pushed
the
add_groups_support
branch
2 times, most recently
from
23d549e to
8ca02dc
Compare
This patch allows to add a 'groups' statement to each part, define one or more groups for each one, and use the groups for dependency management. This way, it is possible to add all the binaries and libraries parts to a "binaries" group, and make another part deppend on that group (just using the 'after' statement like with a part name). This is mainly useful in big snapcraft.yaml files with a lot of parts, like the gnome-XX-sdk ones. This MR replaces canonical/snapcraft#3823
sergio-costas
force-pushed
the
add_groups_support
branch
from
8ca02dc to
cc2b2bf
Compare
|
@sergiusens This seems to work fine. |
|
Alternate names for the option would be "set", "cluster" or "unit"... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to add a 'groups' statement to each part,
define one or more groups for each one, and use the groups for
dependency management.
This way, it is possible to add all the binaries and libraries
parts to a "binaries" group, and make another part deppend on
that group (just using the 'after' statement like with a part
name).
This is mainly useful in big snapcraft.yaml files with a lot
of parts, like the gnome-XX-sdk ones.
This MR replaces canonical/snapcraft#3823