feat(application): enable build plans #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmatsuoka
commented
Sep 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 98.70% 98.39% -0.31%
==========================================
Files 21 22 +1
Lines 693 749 +56
Branches 101 109 +8
==========================================
+ Hits 684 737 +53
- Misses 7 9 +2
- Partials 2 3 +1
|
Enable multi-artefact builds by using the application-defined build plan resolver to create multiple provider instances. Further refactoring may be necessary if applications such as Rockcraft and Charmcraft require additional features. Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
issue-60/get_build_plan
branch
from
8a6de1f to
d9323c3
Compare
|
Rebased on main. |
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
issue-60/get_build_plan
branch
3 times, most recently
from
e5bbafe to
27e48d3
Compare
Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
issue-60/get_build_plan
branch
from
27e48d3 to
c0574b6
Compare
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
issue-60/get_build_plan
branch
4 times, most recently
from
fa6e0e6 to
53c6bbc
Compare
Support for outer commands that need project to be loaded. Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
issue-60/get_build_plan
branch
from
53c6bbc to
8bd11bd
Compare
sergiusens
approved these changes
Sep 12, 2023
tigarmo
reviewed
Sep 12, 2023
tigarmo
reviewed
Sep 17, 2023
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
Build-on filtering now done on application base class. Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
tigarmo
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable multi-artefact builds by using the application-defined build plan
resolver to create multiple provider instances. Further refactoring may
be necessary if applications such as Rockcraft and Charmcraft require
additional features.
Fixes #60
Signed-off-by: Claudio Matsuoka [email protected]
Note
runmethod proved to be problematic in certain situations, this can be refactored later if needed.tox?