-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cli and platform utils #599
feat: add cli and platform utils #599
Conversation
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
Signed-off-by: Dariusz Duda <[email protected]>
4ba2581
to
a7f32a8
Compare
Signed-off-by: Dariusz Duda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
- Coverage 99.28% 90.39% -8.90%
==========================================
Files 29 66 +37
Lines 1265 3987 +2722
Branches 209 454 +245
==========================================
+ Hits 1256 3604 +2348
- Misses 6 295 +289
- Partials 3 88 +85 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alex Lowe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Dariusz Duda <[email protected]>
tox
?Migrate
format_timestamp
cli util fromcharmcraft
.Add
is_managed_mode
andget_hostname
platform helpers.(CRAFT-3739)