Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cli and platform utils #599

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

dariuszd21
Copy link
Contributor

@dariuszd21 dariuszd21 commented Dec 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Migrate format_timestamp cli util from charmcraft.
Add is_managed_mode and get_hostname platform helpers.

(CRAFT-3739)

@dariuszd21 dariuszd21 force-pushed the work/CRAFT-3739-add-utils branch from 4ba2581 to a7f32a8 Compare December 20, 2024 13:25
@dariuszd21 dariuszd21 changed the title feat: add utils feat: add cli and platform utils Dec 20, 2024
Signed-off-by: Dariusz Duda <[email protected]>
@dariuszd21 dariuszd21 requested review from tigarmo and lengau December 20, 2024 13:30
@dariuszd21 dariuszd21 marked this pull request as ready for review December 20, 2024 13:30
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (0705676) to head (70eb7d0).
Report is 334 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0705676) and HEAD (70eb7d0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0705676) HEAD (70eb7d0)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   99.28%   90.39%   -8.90%     
==========================================
  Files          29       66      +37     
  Lines        1265     3987    +2722     
  Branches      209      454     +245     
==========================================
+ Hits         1256     3604    +2348     
- Misses          6      295     +289     
- Partials        3       88      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dariuszd21 dariuszd21 requested a review from lengau December 20, 2024 16:50
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dariuszd21 dariuszd21 merged commit 8e9893d into canonical:main Dec 20, 2024
11 of 12 checks passed
@dariuszd21 dariuszd21 deleted the work/CRAFT-3739-add-utils branch December 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants