fix: do not log encoded secrets #596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 99.28% 90.36% -8.93%
==========================================
Files 29 65 +36
Lines 1265 3976 +2711
Branches 209 456 +247
==========================================
+ Hits 1256 3593 +2337
- Misses 6 295 +289
- Partials 3 88 +85 ☔ View full report in Codecov by Sentry. |
dariuszd21
force-pushed
the
work/mark-craft-secrets-value
branch
3 times, most recently
from
27ca53e to
f6b1f87
Compare
dariuszd21
force-pushed
the
work/mark-craft-secrets-value
branch
from
f6b1f87 to
edcfa2b
Compare
Signed-off-by: Dariusz Duda <[email protected]>
dariuszd21
force-pushed
the
work/mark-craft-secrets-value
branch
from
edcfa2b to
19faa83
Compare
lengau
reviewed
Dec 17, 2024
docs/reference/changelog.rst
Outdated
| @@ -4,6 +4,16 @@ | |||
| Changelog | |||
| ********* | |||
|
|
|||
| 4.7.0 (YYYY-MMM-DD) | |||
There was a problem hiding this comment.
Should we do this in a 4.6.1 patch release?
mattculler
approved these changes
Dec 17, 2024
lengau
reviewed
Dec 17, 2024
lengau
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Since @mattculler agrees I've gone ahead and re-targeted this at the 4.6 hotfix branch. I can celease as soon as @medubelko approves the changelog.
medubelko
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Encoded secrets leak in the logs of the host instance, when managed instance is about to run. If additionally subsequent process fails, value is printed again in the failure traceback.
As they're only encoded not encrypted we should take a precautions and hide those values from the user.