Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use the latest ruff config from starbase #588

Merged
merged 7 commits into from
Dec 19, 2024
Merged

chore: use the latest ruff config from starbase #588

merged 7 commits into from
Dec 19, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 12, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau marked this pull request as ready for review December 12, 2024 04:27
@lengau lengau requested review from dariuszd21 and bepri December 12, 2024 04:28
dariuszd21
dariuszd21 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Will there be a follow up with replacing black with ruff format 😄 ?

@lengau
Copy link
Contributor Author

lengau commented Dec 19, 2024

@dariuszd21 - yes, this is part of the project to migrate craft-application to starflow.

@lengau lengau force-pushed the work/starbase-ruff branch from ed1bf9c to 44d820d Compare December 19, 2024 16:03
@lengau lengau merged commit 44b1a94 into main Dec 19, 2024
10 checks passed
@lengau lengau deleted the work/starbase-ruff branch December 19, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bepri bepri bepri approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @dariuszd21 @bepri