refactor: extract common code from CharmRecipe #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class will hold the implementation that is valid for all non-snap recipe types. For now it's just the previous CharmRecipe - the next commit will do the generalization work.
Subclasses must provide the name of the artifact (charm, rock, etc) and the launchpad object that wraps the utility to manipulate recipes.
tigarmo
force-pushed
the
work/refactor-recipe
branch
from
8b4a06d to
724c648
Compare
bepri
requested changes
Dec 10, 2024
lengau
reviewed
Dec 10, 2024
lengau
reviewed
Dec 10, 2024
tigarmo
force-pushed
the
work/refactor-recipe
branch
from
ab60420 to
8a606f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in CharmRecipe is 99% artifact-type-agnostic; generalize it out so that we can provide more artifact types with little new code.
The first commit just "renames" the existing CharmRecipe to _StandardRecipe; the second commit then has the actual changes to generalize the class, with the concrete CharmRecipe implementation.