Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ruff and fix linting issue #115

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Oct 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau requested a review from a team October 21, 2023 20:39
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #115 (3318a79) into main (783371a) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   99.11%   99.01%   -0.10%     
==========================================
  Files          24       24              
  Lines        1015     1015              
  Branches      162      163       +1     
==========================================
- Hits         1006     1005       -1     
  Misses          6        6              
- Partials        3        4       +1     
Files Coverage Δ
craft_application/__init__.py 100.00% <ø> (ø)
craft_application/application.py 96.91% <100.00%> (-0.02%) ⬇️
craft_application/errors.py 100.00% <ø> (ø)
craft_application/services/__init__.py 100.00% <100.00%> (ø)
craft_application/services/base.py 100.00% <100.00%> (ø)
craft_application/services/lifecycle.py 97.61% <100.00%> (ø)
craft_application/services/package.py 100.00% <100.00%> (ø)
craft_application/services/provider.py 100.00% <100.00%> (ø)
craft_application/services/service_factory.py 97.05% <92.85%> (-2.95%) ⬇️

@lengau lengau force-pushed the style/format-ruff branch from 19f7b39 to 570151f Compare October 23, 2023 16:19
@lengau lengau force-pushed the style/format-ruff branch from 570151f to 14374d2 Compare October 23, 2023 17:51
@lengau lengau merged commit 59ab004 into main Oct 24, 2023
@lengau lengau deleted the style/format-ruff branch October 24, 2023 15:55
lengau pushed a commit that referenced this pull request Jul 16, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants