Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set log level for all craft libs #111

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat: set log level for all craft libs #111

merged 1 commit into from
Oct 23, 2023

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Oct 20, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #111 (a243c94) into main (1bbc367) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   99.10%   99.11%           
=======================================
  Files          24       24           
  Lines        1010     1015    +5     
  Branches      161      162    +1     
=======================================
+ Hits         1001     1006    +5     
  Misses          6        6           
  Partials        3        3
Files Coverage Δ
craft_application/application.py 96.92% <100.00%> (+0.06%) ⬆️

@tigarmo tigarmo marked this pull request as ready for review October 20, 2023 20:54
@tigarmo tigarmo requested review from lengau and sergiusens October 20, 2023 20:54
@tigarmo tigarmo force-pushed the craft-logger-levels branch from 978accb to a243c94 Compare October 23, 2023 15:07
@lengau lengau merged commit e092315 into main Oct 23, 2023
@lengau lengau deleted the craft-logger-levels branch October 23, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigarmo @sergiusens @lengau