-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support build-secrets in managed-mode #104
Conversation
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 99.07% 99.11% +0.04%
==========================================
Files 24 24
Lines 970 1015 +45
Branches 156 162 +6
==========================================
+ Hits 961 1006 +45
Misses 6 6
Partials 3 3
|
This is done by encoding the secrets, in the host-application, into the environment of the managed instance. The managed instance then decodes this environment and uses it to re-render the project secrets.
fa168ce
to
0a50456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation matches what was explained, overall this looks like a nice solution!
This is done by encoding the secrets, in the host-application, into the environment of the managed instance. The managed instance then decodes this environment and uses it to re-render the project secrets.
tox
?