Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support build-secrets in managed-mode #104

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Oct 18, 2023

This is done by encoding the secrets, in the host-application, into the environment of the managed instance. The managed instance then decodes this environment and uses it to re-render the project secrets.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #104 (ed5b524) into main (4c96df5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head ed5b524 differs from pull request most recent head 0e69345. Consider uploading reports for the commit 0e69345 to get more accurate results

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   99.07%   99.11%   +0.04%     
==========================================
  Files          24       24              
  Lines         970     1015      +45     
  Branches      156      162       +6     
==========================================
+ Hits          961     1006      +45     
  Misses          6        6              
  Partials        3        3              
Files Coverage Δ
craft_application/application.py 96.92% <100.00%> (+0.14%) ⬆️
craft_application/errors.py 100.00% <100.00%> (ø)
craft_application/secrets.py 100.00% <100.00%> (ø)

This is done by encoding the secrets, in the host-application, into the
environment of the managed instance. The managed instance then decodes
this environment and uses it to re-render the project secrets.
@tigarmo tigarmo force-pushed the CRAFT-2152-secrets-managed branch from fa168ce to 0a50456 Compare October 18, 2023 11:52
@tigarmo tigarmo marked this pull request as ready for review October 18, 2023 12:51
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation matches what was explained, overall this looks like a nice solution!

@tigarmo tigarmo merged commit 8c6c047 into main Oct 19, 2023
@tigarmo tigarmo deleted the CRAFT-2152-secrets-managed branch October 19, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants