Do not keep stale targets in csv file #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
requested review from
Abuelodelanada,
PietroPasotti,
dstathis,
simskij and
lucabello
as code owners
sed-i
commented
Nov 14, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lucabello
approved these changes
Nov 14, 2023
przemeklal
approved these changes
Nov 15, 2023
|
@sed-i seems your commits are not signed so i can't merge. can you look into this? thanks. |
* Update badges in README.md * fix copy-paste
sed-i
force-pushed
the
feature/fix-append
branch
from
eb28349 to
335de07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When nrpe changed prefix, cos-proxy failed to correctly calculate the current list of targets, keeping stale rows in the file.
Solution
Make sure stale targets are not kept, by correctly looking up entries in the csv.
Fixes #93.