Adding cos agent relation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbraAoad
requested review from
Abuelodelanada,
dstathis,
lucabello,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
mmkay
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Nice! Added a few comments but I'd also like someone else from the team to look at it as I don't have the full COS proxy context.
Most of my comments are suggesting a bit of defensive approach around parsing / saving dashboards. If you feel like that's not needed feel free to push back.
dstathis
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
cos-agentrelation, enabling the connection of cos-proxy to a charm requiring the relation, such asgrafana-agent. With this relation,cos-proxycan transmit data such as metric rules, Grafana dashboards, and scrape jobs from the charms it's proxying tografana-agent. This eliminates the need to directly connect cos-proxy to Prometheus, Grafana, etc.