Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix machine name handling for nrpe_exporter binary #126

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix machine name handling for nrpe_exporter binary #126

merged 3 commits into from
Feb 28, 2024

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Feb 27, 2024 •
edited
Loading

Issue

Incorrect machine name for nrpe binary.

Solution

Hard-code machine names.

Fixes #124.

Testing Instructions

Make sure the follow bundle deploys with no errors:

series: jammy
applications:
  cp:
    # Pack from this PR
    charm: ./cos-proxy_ubuntu-20.04-amd64_ubuntu-22.04-amd64.charm
    num_units: 1
  nrpe:
    charm: nrpe
    channel: edge
    revision: 117
  ub:
    charm: ubuntu
    channel: edge
    revision: 24
    num_units: 1
relations:
- - cp:monitors
  - nrpe:monitors
- - nrpe:general-info
  - ub:juju-info

Upgrade Notes

Normal procedure.

@sed-i sed-i changed the title Update charmcraft.yaml Fix machine name handling for nrpe_exporter binary Feb 27, 2024
@sed-i sed-i marked this pull request as ready for review February 27, 2024 21:27
@sed-i sed-i merged commit 47afacb into main Feb 28, 2024
13 checks passed
@sed-i sed-i deleted the sed-i-patch-1 branch February 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraAoad IbraAoad IbraAoad approved these changes

@lucabello lucabello lucabello approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@dstathis dstathis Awaiting requested review from dstathis

@mmkay mmkay Awaiting requested review from mmkay

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong nrpe exporter binary gets downloaded
3 participants
@sed-i @lucabello @IbraAoad