Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(join): Limit join retry attempts #118

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

HomayoonAlimohammadi
Copy link

This prevents situations where the join fails indefinitely and we can not see anything in the logs.
Also changed the number of control plane replicas in default cluster.yaml manifest for e2e tests since we're testing rolling upgrades with that manifest.

This prevents situations where the join fails indefinitely and we can not see anything in the logs
@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team October 23, 2024 09:02
Copy link

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit 4f04eb7 into main Oct 24, 2024
4 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the limit-join-retries branch October 24, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants