Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify impl. of DisableDefaultCNI field #110

Merged
merged 1 commit into from
Jul 31, 2024
Merged

simplify impl. of DisableDefaultCNI field #110

merged 1 commit into from
Jul 31, 2024

Conversation

eaudetcobello
Copy link

@eaudetcobello eaudetcobello commented Jul 30, 2024 •
edited
Loading

Removed custom script in favor of passing true or false as an argument to the existing 00-install-microk8s.sh script.

neoaggelos
neoaggelos suggested changes Jul 30, 2024
View reviewed changes
controllers/cloudinit/controlplane_join.go Outdated Show resolved Hide resolved
controllers/cloudinit/utils.go Outdated Show resolved Hide resolved
controllers/cloudinit/worker_join.go Outdated Show resolved Hide resolved
controllers/cloudinit/scripts/00-install-microk8s.sh Outdated Show resolved Hide resolved
controllers/cloudinit/scripts/00-install-microk8s.sh Outdated Show resolved Hide resolved
controllers/cloudinit/scripts/00-install-microk8s.sh Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello requested a review from neoaggelos July 30, 2024 21:18
@eaudetcobello eaudetcobello changed the title simplify impl. of disabledefaultcni simplify impl. of DisableDefaultCNI field Jul 30, 2024
neoaggelos
neoaggelos approved these changes Jul 31, 2024
View reviewed changes
Copy link

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally we would want a CI test for this.

@eaudetcobello eaudetcobello force-pushed the eaudetcobello/KU-1189 branch from d262fb4 to 869ed51 Compare July 31, 2024 20:07
@eaudetcobello eaudetcobello merged commit 6fa2d76 into main Jul 31, 2024
4 checks passed
@eaudetcobello eaudetcobello deleted the eaudetcobello/KU-1189 branch July 31, 2024 20:12
@maci3jka maci3jka mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoaggelos neoaggelos neoaggelos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaudetcobello @neoaggelos