Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bootstrap chisel docs #186

Closed

Conversation

cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Dec 16, 2024

  • Have you signed the CLA?

Needs #185

This PR creates the first version of the Chisel docs.

More doc pages and functionality are planned for coming PRs, such as:

  • doc versioning
  • ci checks
  • additional guides
  • additional explanation pages to dive deeper into the different cut stages (e.g. the process of fetching, parsing and validating an Ubuntu release)
  • etc.

preview: https://canonical-chisel--186.com.readthedocs.build/en/186/

rebornplusplus and others added 30 commits December 16, 2024 17:27
This commit adds a skeleton of the documentation based on docs starter
pack: https://canonical-starter-pack.readthedocs-hosted.com/latest/.

Note that the docs themselves are not updated. Only necessary files and
hacks are introduced in this commit.
Read reuse/substitutions.yaml if it exists into myst_substitutions to
reuse content with simple markdown.

Additionally, delete reuse/links.txt since we are not using
reStructuredText.

This commit also updates a few misc settings in conf.py.
Update the site landing page (/) at docs/index.md with a summary of
Chisel and proper links to different sections.

This commit also creates a few placeholder files and directories for
later use, e.g. reference/, how-to/index.md etc.
Additionally add placeholder CLI commands reference pages.
This commit adds reference pages for all Chisel subcommands.
@cjdcordeiro cjdcordeiro marked this pull request as draft December 16, 2024 16:53
@cjdcordeiro cjdcordeiro marked this pull request as ready for review December 16, 2024 16:53
@cjdcordeiro cjdcordeiro added the Blocked Waiting for something external label Dec 16, 2024
@cjdcordeiro
Copy link
Collaborator Author

FYI @yhontyk

Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, this is all the code that the starter pack generates automatically.

EDIT: My bad I had the two tabs open and selected the wrong PR. Will review this one properly.

@letFunny letFunny self-requested a review January 7, 2025 11:43
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing Cristovao and Rafid! I think this is exactly what we were looking for in the first complete version of the documentation. It is comprehensive and detailed, it is correct from a technical point of view, and yet it does not feel unnecessarily verbose. LGTM!

docs/index.md Show resolved Hide resolved
docs/tutorial/getting-started.md Show resolved Hide resolved
docs/explanation/mode-of-operation.md Show resolved Hide resolved
docs/reference/cmd/find.md Show resolved Hide resolved
docs/reference/cmd/find.md Show resolved Hide resolved
docs/reference/chisel-releases/chisel.yaml.md Show resolved Hide resolved
docs/reference/chisel-releases/chisel.yaml.md Show resolved Hide resolved
Comment on lines +188 to +191
```{note}
This field is only applicable to paths with no wildcards, and its value
must also be an absolute path with no wildcards.
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be an attribute in the table above so that it is uniform for all attributes. Thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be pragmatic, my opinion is:

  • we'd eventually want to auto generate this page from the code itself. In that case, such attribute would probably be a bit trickier to generate from the code (?)
  • there are more fields without this note, than with it, so in the sake of avoiding empty space within the tables, I'd just keep it as it

system.

It currently accepts only one value - `mutate`. If specified, the path will only
be available until the {{mutation_scripts}} execute, and is removed afterwards.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit more nuanced. Basically the file is removed as soon as no other slices need it. For example, one slice may need it only until mutation but the other may use until: none meaning it will need it in the final filesystem. Because it is needed, the file is not removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to rephrase it. Please check the coming update on canonical/chisel-docs#4

docs/reference/manifest.md Show resolved Hide resolved
@cjdcordeiro
Copy link
Collaborator Author

@letFunny your comments have been addressed in canonical/chisel-docs@71c2694

FYI @yhontyk this is being moved to canonical/chisel-docs#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Waiting for something external
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants