-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: expose manifest reading and jsonwall as packages #182
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll likely need to add the new licensing headers to each one of these source files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the licensing headers. they lgtm
Note pls ignore the failed RTD check. I've enabled the automatic generation of PR docs, which will start passing once #185 is merged |
"io" | ||
"slices" | ||
|
||
"github.com/canonical/chisel/internal/setup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that chisel/internal is under AGPL, is this ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I am not sure. I have to read more about licensing, but it looks like it will not be okay, we would have to extract the common components into a Apache-2.0 package that is imported by both the AGPL and this one, but I am not really sure.
|
||
. "gopkg.in/check.v1" | ||
|
||
"github.com/canonical/chisel/internal/testutil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here as above
I am blocking this until we solve all the questions regarding copyright and licensing. |
References:
Relevant excerpts: