Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for "v2-archives" in "v1" format #181

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

letFunny
Copy link
Collaborator

"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0 since it will be ignored. In new versions, it will be parsed with the new fields that break said compatibility, e.g. "pro" archives.

  • Have you signed the CLA?

"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0
since it will be ignored. In new versions, it will be parsed with the new
fields that break said compatibility, e.g. "pro" archives.
@cjdcordeiro cjdcordeiro added the Priority Look at me first label Dec 13, 2024
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! The only detail that needs tuning is the comment, as outlined below:

// since it will be ignored. In new versions, it will be parsed with the new
// fields that break said compatibility, e.g. "pro" archives.
//
// Note: "archives" and "v2-archives" are merged together while parsing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment needs tuning as it's currently saying that it will both be ignored, in the very first sentence, and it will be merged together, at the end. It needs to s/v1.0.0 since/v1.0.0, where/, or similar.

@niemeyer
Copy link
Contributor

Since this PR is high priority, and the only detail is in the comment, I'm merging it right away. Let's please fix the comment in a forthcoming PR.

@niemeyer niemeyer merged commit b531453 into canonical:main Dec 13, 2024
14 checks passed
cjdcordeiro pushed a commit to cjdcordeiro/chisel that referenced this pull request Dec 16, 2024
"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0
since it will be ignored. In new versions, it will be parsed with the new
fields that break said compatibility, e.g. "pro" archives.

Co-authored-by: Rafid Bin Mostofa <[email protected]>
cjdcordeiro pushed a commit to cjdcordeiro/chisel that referenced this pull request Dec 16, 2024
"v2-archives" is used for backwards compatibility with Chisel <= 1.0.0
since it will be ignored. In new versions, it will be parsed with the new
fields that break said compatibility, e.g. "pro" archives.

Co-authored-by: Rafid Bin Mostofa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants