Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicit parents override implicit #166

Merged
merged 5 commits into from
Nov 15, 2024
Merged

fix: explicit parents override implicit #166

merged 5 commits into from
Nov 15, 2024

Conversation

letFunny
Copy link
Collaborator

  • Have you signed the CLA?

This commits introduces a new flag for fsutil.Create called OverrideMode which updates the mode of existing entries. It is used to ensure that the explicit folder overrides the permissions of the implicit ones.

@letFunny letFunny added Bug An undesired feature ;-) Simple Nice for a quick look on a minute or two labels Oct 17, 2024
rebornplusplus
rebornplusplus reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks. Left a couple of comments.

internal/fsutil/create_test.go Show resolved Hide resolved
internal/fsutil/create_test.go Show resolved Hide resolved
internal/slicer/slicer_test.go Outdated Show resolved Hide resolved
rebornplusplus
rebornplusplus approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! :)

niemeyer
niemeyer approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. One suggestion only, optional.

internal/fsutil/create.go Outdated Show resolved Hide resolved
internal/deb/extract.go Show resolved Hide resolved
niemeyer
niemeyer approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@niemeyer niemeyer merged commit ccfe87a into canonical:main Nov 15, 2024
13 checks passed
@niemeyer niemeyer changed the title bugfix: explicit parents override implicit fix: explicit parents override implicit Nov 15, 2024
@niemeyer
Copy link
Contributor

Side note: the summary prefix is "fix", not "bugfix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornplusplus rebornplusplus rebornplusplus approved these changes

@niemeyer niemeyer niemeyer approved these changes

Assignees
No one assigned
Labels
Bug An undesired feature ;-) Simple Nice for a quick look on a minute or two
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@letFunny @niemeyer @rebornplusplus