Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish release checksums #155

Merged

Conversation

rebornplusplus
Copy link
Member

@rebornplusplus rebornplusplus commented Aug 28, 2024

On release events, publish checksum of the binary tarballs that we already publish.

Closes #122.

@rebornplusplus rebornplusplus marked this pull request as ready for review August 28, 2024 14:42
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ;)

Just a couple of small corrections/improvements

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro added the Simple Nice for a quick look on a minute or two label Aug 30, 2024
The goal is to improve maintainability, because ``dist/`` was hardcoded
in multiple steps.
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the changes

@cjdcordeiro cjdcordeiro self-assigned this Sep 26, 2024
@cjdcordeiro cjdcordeiro merged commit ac90003 into canonical:main Sep 26, 2024
14 checks passed
@cjdcordeiro
Copy link
Collaborator

Discussed offline and deemed ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple Nice for a quick look on a minute or two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksums for release assets?
2 participants