Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Spread tests run for multiple chisel-releases #114

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

  • Have you signed the CLA?

Up to now, the Spread tests were only running for the ubuntu-22.04 chisel release.
This PR extends the spread variants, for each spread task, such that the tests run on all supported chisel releases

Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw tests passing in the meeting. Looking good

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cjdcordeiro
Copy link
Collaborator Author

Thanks for the review. Merging as it's only impacting the CI tests

@cjdcordeiro cjdcordeiro merged commit 0c32d94 into canonical:main Jan 12, 2024
14 checks passed
@cjdcordeiro cjdcordeiro deleted the spread-multi-release branch January 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants