Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add SDF for file and dependencies #453

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

eunufe
Copy link

@eunufe eunufe commented Jan 8, 2025

Proposed changes

feat(24.04): add SDF for file and dependencies

Related issues/PRs

Forward porting

#454

Checklist

Additional Context

Copy link

github-actions bot commented Jan 8, 2025

Diff of dependencies:
None found.


Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the contribution!

Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for these two missing symlinks, this PR looks overall good to me.

slices/libmagic-mgc.yaml Show resolved Hide resolved
@eunufe eunufe requested a review from zhijie-yang January 10, 2025 14:24
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They now look nice! Thanks for the code!

@cjdcordeiro cjdcordeiro merged commit ded20ce into canonical:ubuntu-24.04 Jan 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants