Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(24.04): add SDF for cpio #447

Merged
merged 5 commits into from
Jan 16, 2025
Merged

feat(24.04): add SDF for cpio #447

merged 5 commits into from
Jan 16, 2025

Conversation

eunufe
Copy link

@eunufe eunufe commented Jan 6, 2025 •
edited
Loading

Proposed changes

feat(24.04): add SDF for cpio

Related issues/PRs

Forward porting

#448

Checklist

Additional Context

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Diff of dependencies:
None found.

@eunufe eunufe mentioned this pull request Jan 6, 2025
Merged
3 tasks
@cjdcordeiro cjdcordeiro mentioned this pull request Jan 7, 2025
Merged
3 tasks
@eunufe eunufe requested a review from cjdcordeiro January 10, 2025 13:20
zhijie-yang
zhijie-yang requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code. Some nitpicks below.

slices/cpio.yaml Outdated Show resolved Hide resolved
tests/spread/integration/cpio/task.yaml Outdated Show resolved Hide resolved
tests/spread/integration/cpio/task.yaml Outdated Show resolved Hide resolved
zhijie-yang
zhijie-yang approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks for the change!

cjdcordeiro
cjdcordeiro approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the changes ;)

@cjdcordeiro cjdcordeiro merged commit 9d71c49 into canonical:ubuntu-24.04 Jan 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhijie-yang zhijie-yang zhijie-yang approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunufe @cjdcordeiro @zhijie-yang