-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add slices for Gearman and dependencies #443
base: ubuntu-24.04
Are you sure you want to change the base?
Conversation
Diff of dependencies: slices/gearman-job-server.yaml@@ -1,4 +1,3 @@
-adduser
libboost-program-options1.83.0
libc6
libevent-2.1-7t64 |
46c025e
to
e338190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very tidy! Thanks for the contribution. It LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we might just need a fix on the linting (see the CI checks).
As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.
@eunufe Can you review and clean-up the trailing whitespace characters the linter detected? I missed them in our internal review of this. |
@cjdcordeiro Eloho signed the CLA several weeks ago, so I think some sort of manual action is required for you database. |
Yep I saw your message in #444 and have already reached out to my colleagues to get it sorted out. Once I hear back from them I'll re-run the check ;) |
Great, thanks! |
@cjdcordeiro Something appears to not be working correctly the YAML linter action. |
Oops, disregard. |
Sort bin essential entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. The CLA is also passing now ;)
Proposed changes
feat(24.04): add slices for Gearman and dependencies
Related issues/PRs
Forward porting
#444
Checklist
Additional Context