Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add slices for Gearman and dependencies #443

Open
wants to merge 5 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

eunufe
Copy link

@eunufe eunufe commented Dec 30, 2024

Proposed changes

feat(24.04): add slices for Gearman and dependencies

Related issues/PRs

Forward porting

#444

Checklist

Additional Context

Copy link

github-actions bot commented Dec 30, 2024

Diff of dependencies:

slices/gearman-job-server.yaml
@@ -1,4 +1,3 @@
-adduser
 libboost-program-options1.83.0
 libc6
 libevent-2.1-7t64

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tidy! Thanks for the contribution. It LGTM.

@cjdcordeiro cjdcordeiro self-requested a review January 6, 2025 11:24
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we might just need a fix on the linting (see the CI checks).

As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@norrisjeremy
Copy link

Ah, we might just need a fix on the linting (see the CI checks).

As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@eunufe Can you review and clean-up the trailing whitespace characters the linter detected? I missed them in our internal review of this.

@norrisjeremy
Copy link

Ah, we might just need a fix on the linting (see the CI checks).

As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@cjdcordeiro Eloho signed the CLA several weeks ago, so I think some sort of manual action is required for you database.

@cjdcordeiro
Copy link
Collaborator

Ah, we might just need a fix on the linting (see the CI checks).
As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@cjdcordeiro Eloho signed the CLA several weeks ago, so I think some sort of manual action is required for you database.

Yep I saw your message in #444 and have already reached out to my colleagues to get it sorted out. Once I hear back from them I'll re-run the check ;)

@norrisjeremy
Copy link

Ah, we might just need a fix on the linting (see the CI checks).
As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@cjdcordeiro Eloho signed the CLA several weeks ago, so I think some sort of manual action is required for you database.

Yep I saw your message in #444 and have already reached out to my colleagues to get it sorted out. Once I hear back from them I'll re-run the check ;)

Great, thanks!

@norrisjeremy
Copy link

Ah, we might just need a fix on the linting (see the CI checks).
As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@eunufe Can you review and clean-up the trailing whitespace characters the linter detected? I missed them in our internal review of this.

@cjdcordeiro Something appears to not be working correctly the YAML linter action.
Eloho pushed a change to fix the trailing whitespace, but now it appears to be issuing warnings for other unrelated SDFs?

@norrisjeremy
Copy link

Ah, we might just need a fix on the linting (see the CI checks).
As for the CLA, please let me know if you've signed it, cause if so, it might need some manual action on our side.

@eunufe Can you review and clean-up the trailing whitespace characters the linter detected? I missed them in our internal review of this.

@cjdcordeiro Something appears to not be working correctly the YAML linter action. Eloho pushed a change to fix the trailing whitespace, but now it appears to be issuing warnings for other unrelated SDFs?

Oops, disregard.
The issue was buried in the avalanche of warnings that the linter output for all the existing SDFs.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. The CLA is also passing now ;)

@cjdcordeiro cjdcordeiro requested a review from a team January 6, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants